Add RPC provider: Infura #7286
Open
Add RPC provider: Infura #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 8f44a50 | Previous: efac906 | Ratio |
|---|---|---|---|
processingTx |
22585 ops/sec (±8.95%) |
23741 ops/sec (±5.98%) |
1.05 |
processingContractDeploy |
39800 ops/sec (±7.19%) |
39369 ops/sec (±11.37%) |
0.99 |
processingContractMethodSend |
16334 ops/sec (±7.12%) |
17405 ops/sec (±6.68%) |
1.07 |
processingContractMethodCall |
28182 ops/sec (±6.17%) |
28770 ops/sec (±6.60%) |
1.02 |
abiEncode |
43191 ops/sec (±7.93%) |
44377 ops/sec (±8.86%) |
1.03 |
abiDecode |
31121 ops/sec (±5.77%) |
31118 ops/sec (±7.50%) |
1.00 |
sign |
1508 ops/sec (±3.84%) |
1604 ops/sec (±0.56%) |
1.06 |
verify |
359 ops/sec (±0.69%) |
369 ops/sec (±2.79%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7286 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 217 217
Lines 8487 8487
Branches 2343 2343
=======================================
Hits 8021 8021
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
reviewed
Sep 26, 2024
jdevcs
reviewed
Sep 26, 2024
krzysu
reviewed
Oct 2, 2024
danforbes
approved these changes
Oct 28, 2024
|
|
||
| BASE_MAINNET = 'base_mainnet', | ||
| BASE_SEPOLIA = 'base_sepolia', | ||
| BASE_GOERLI = 'base_foerli', |
There was a problem hiding this comment.
Suggested change
| BASE_GOERLI = 'base_foerli', | |
| BASE_GOERLI = 'base_goerli', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6975
All tests passed locally
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.